test
test
- while ($contentBlock->childNodes->length === 1 && $contentBlock->firstChild->nodeType === XML_ELEMENT_NODE) { + while (1 === $contentBlock->childNodes->length && XML_ELEMENT_NODE === $contentBlock->firstChild->nodeType) { // only follow these tag names if (!in_array(strtolower($contentBlock->tagName), ['div', 'article', 'section', 'header', 'footer'], true)) { break; @@ -215,7 +215,7 @@ public function cleanupHtml($contentBlock, $url) // post-processing cleanup $html = preg_replace('![\s\h\v]*
!u', '', $html); - if ($this->config['content_links'] === 'remove') { + if ('remove' === $this->config['content_links']) { $html = preg_replace('!]*>!', '', $html); } @@ -408,7 +408,7 @@ private function validateUrl($url) { // Check for feed URL $url = trim($url); - if (strtolower(substr($url, 0, 7)) === 'feed://') { + if ('feed://' === strtolower(substr($url, 0, 7))) { $url = 'http://' . substr($url, 7); } @@ -458,13 +458,13 @@ private function isUrlAllowed($url) if (!empty($allowedUrls)) { foreach ($allowedUrls as $allowurl) { - if (stristr($url, $allowurl) !== false) { + if (false !== stristr($url, $allowurl)) { return true; } } } else { foreach ($blockedUrls as $blockurl) { - if (stristr($url, $blockurl) !== false) { + if (false !== stristr($url, $blockurl)) { return false; } } @@ -551,11 +551,11 @@ private function handleMimeAction($mimeInfo, $effectiveUrl, $response = []) $infos['html'] = 'Download ' . $mimeInfo['name'] . ''; - if ($mimeInfo['type'] === 'image') { + if ('image' === $mimeInfo['type']) { $infos['html'] = '' .
$this->cleanupXss(
$this->convert2Utf8($body, isset($response['all_headers']) ? $response['all_headers'] : [])
@@ -918,7 +918,7 @@ private function convert2Utf8($html, array $headers = [])
// If it's not, result will be empty string.
// For now we'll check for invalid encoding types returned by some sites, e.g. 'none'
// Problem URL: http://facta.co.jp/blog/archives/20111026001026.html
- if (empty($encoding) || $encoding === 'none') {
+ if (empty($encoding) || 'none' === $encoding) {
// search for encoding in HTML - only look at the first 50000 characters
// Why 50000? See, for example, http://www.lemonde.fr/festival-de-cannes/article/2012/05/23/deux-cretes-en-goguette-sur-la-croisette_1705732_766360.html
// TODO: improve this so it looks at smaller chunks first
@@ -940,11 +940,11 @@ private function convert2Utf8($html, array $headers = [])
$encoding = strtolower(trim($encoding));
// fix bad encoding values
- if ($encoding === 'iso-8850-1') {
+ if ('iso-8850-1' === $encoding) {
$encoding = 'iso-8859-1';
}
- if (empty($encoding) || $encoding === 'iso-8859-1') {
+ if (empty($encoding) || 'iso-8859-1' === $encoding) {
// replace MS Word smart qutoes
$trans = [];
$trans[chr(130)] = '‚'; // Single Low-9 Quotation Mark
@@ -974,7 +974,7 @@ private function convert2Utf8($html, array $headers = [])
$html = strtr($html, $trans);
}
- if ($encoding !== 'utf-8') {
+ if ('utf-8' !== $encoding) {
// https://www.w3.org/International/articles/http-charset/index#charset
// HTTP 1.1 says that the default charset is ISO-8859-1
$encoding = $encoding ?: 'iso-8859-1';
diff --git a/src/SiteConfig/ConfigBuilder.php b/src/SiteConfig/ConfigBuilder.php
index 1aeb6d33..667136e7 100644
--- a/src/SiteConfig/ConfigBuilder.php
+++ b/src/SiteConfig/ConfigBuilder.php
@@ -54,7 +54,7 @@ public function setLogger(LoggerInterface $logger)
public function addToCache($key, SiteConfig $config)
{
$key = strtolower($key);
- if (substr($key, 0, 4) === 'www.') {
+ if ('www.' === substr($key, 0, 4)) {
$key = substr($key, 4);
}
@@ -78,7 +78,7 @@ public function addToCache($key, SiteConfig $config)
public function getCachedVersion($key)
{
$key = strtolower($key);
- if (substr($key, 0, 4) === 'www.') {
+ if ('www.' === substr($key, 0, 4)) {
$key = substr($key, 4);
}
@@ -128,7 +128,7 @@ public function buildFromUrl($url, $addToCache = true)
public function buildForHost($host, $addToCache = true)
{
$host = strtolower($host);
- if (substr($host, 0, 4) === 'www.') {
+ if ('www.' === substr($host, 0, 4)) {
$host = substr($host, 4);
}
@@ -201,7 +201,7 @@ public function build($host, $exactHostMatch = false)
public function loadSiteConfig($host, $exactHostMatch = false)
{
$host = strtolower($host);
- if (substr($host, 0, 4) === 'www.') {
+ if ('www.' === substr($host, 0, 4)) {
$host = substr($host, 4);
}
@@ -315,20 +315,20 @@ public function parseLines(array $lines)
$line = trim($line);
// skip comments, empty lines
- if ($line === '' || $line[0] === '#') {
+ if ('' === $line || '#' === $line[0]) {
continue;
}
// get command
$command = explode(':', $line, 2);
// if there's no colon ':', skip this line
- if (count($command) !== 2) {
+ if (2 !== count($command)) {
continue;
}
$val = trim($command[1]);
$command = trim($command[0]);
- if ($command === '' || $val === '') {
+ if ('' === $command || '' === $val) {
continue;
}
@@ -337,15 +337,15 @@ public function parseLines(array $lines)
array_push($config->$command, $val);
// check for single statement commands that evaluate to true or false
} elseif (in_array($command, ['tidy', 'prune', 'autodetect_on_failure', 'requires_login'], true)) {
- $config->$command = ($val === 'yes' || $val === 'true');
+ $config->$command = ('yes' === $val || 'true' === $val);
// check for single statement commands stored as strings
} elseif (in_array($command, ['parser', 'login_username_field', 'login_password_field', 'not_logged_in_xpath', 'login_uri'], true)) {
$config->$command = $val;
// check for replace_string(find): replace
- } elseif ((substr($command, -1) === ')') && preg_match('!^([a-z0-9_]+)\((.*?)\)$!i', $command, $match) && $match[1] === 'replace_string') {
+ } elseif ((')' === substr($command, -1)) && preg_match('!^([a-z0-9_]+)\((.*?)\)$!i', $command, $match) && 'replace_string' === $match[1]) {
array_push($config->find_string, $match[2]);
array_push($config->replace_string, $val);
- } elseif ((substr($command, -1) === ')') && preg_match('!^([a-z0-9_]+)\(([a-z0-9_-]+)\)$!i', $command, $match) && $match[1] === 'http_header' && in_array($match[2], ['user-agent', 'referer'], true)) {
+ } elseif ((')' === substr($command, -1)) && preg_match('!^([a-z0-9_]+)\(([a-z0-9_-]+)\)$!i', $command, $match) && 'http_header' === $match[1] && in_array($match[2], ['user-agent', 'referer'], true)) {
$config->http_header[$match[2]] = $val;
}
}
diff --git a/tests/Extractor/ContentExtractorTest.php b/tests/Extractor/ContentExtractorTest.php
index 8c139793..9057b8ab 100644
--- a/tests/Extractor/ContentExtractorTest.php
+++ b/tests/Extractor/ContentExtractorTest.php
@@ -94,11 +94,11 @@ public function testBuildSiteConfig()
$this->assertInstanceOf('Graby\SiteConfig\SiteConfig', $res);
- foreach (['author', 'single_page_link', 'next_page_link', 'find_string', 'replace_string'] as $value) {
+ foreach (['author', 'single_page_link', 'next_page_link'] as $value) {
$this->assertEmpty($res->$value, 'Check empty value for: ' . $value);
}
- foreach (['date', 'strip_image_src', 'http_header'] as $value) {
+ foreach (['date', 'strip_image_src', 'http_header', 'find_string', 'replace_string'] as $value) {
$this->assertNotEmpty($res->$value, 'Check not empty value for: ' . $value);
}