Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenCL/LWJGL3 implementation uses deprecated objects like CLDevice #534

Closed
phr00t opened this issue Jul 20, 2016 · 3 comments
Closed

OpenCL/LWJGL3 implementation uses deprecated objects like CLDevice #534

phr00t opened this issue Jul 20, 2016 · 3 comments

Comments

@phr00t
Copy link
Contributor

phr00t commented Jul 20, 2016

The current jME3 OpenCL implementation likely works, but if you try & use the latest LWJGL 3 release, it won't compile. CLDevice wrappers were removed in the latest release:

https://github.com/LWJGL/lwjgl3/releases

... due to this issue:

LWJGL/lwjgl3#152

See current usage of CLDevice here:

https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-lwjgl3/src/main/java/com/jme3/opencl/lwjgl/LwjglDevice.java

They likely want a simple "long" define of the device, instead of CLDevice, which is the address.

@shamanDevel
Copy link
Contributor

Thank you that you noticed that change in the API.
To the core members: Am I allowed to update the dependency of lwjgl3 from 3.0.0b to 3.0.0? Then I can implement the changes.

@shadowislord
Copy link
Member

Yeah, it's okay to update LWJGL3

@shamanDevel
Copy link
Contributor

Can we mark this issue as closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants