-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text tab support and 'my tabs' #17
Conversation
Hey, thanks for contributing- I'm interested in these features. Didn't even know there was a 'my tabs' section. It's not currently working on my end though, I think they may have added another popup after logging in that's interfering, but strangely it's only happening with your updates. I'll investigate. |
Nice, solved the bug? |
Wasn't even a bug really, just missed it the first time I looked and didn't get back to it for awhile. |
|
Thanks for the feedback! Feel free to make a PR for any of these. I'll take a look sometime (ETA in the next month or two). In answer to your question about drum tab support: there's no specific technical reason drums aren't supported. I simply forgot they were a category In answer to your question about "chord tabs". That's fair. Feel free to write a conditional to call chords simply "chords" and make a PR |
Text tabs are newly created .txt files. Other files are downloaded through your browser like you would download a file normally while browsing. |
[Bug Report] Error
|
[Bug]Not Searching for ukuleleit says
|
Adds the 'Text' option to the UI
Adds the ability to download 'My Tabs' (your saved tabs)
Code could be cleaned up a bit, but in my testing it works!