-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: container has runAsNonRoot and image will run as root #105
Comments
Hi @msschl we can set some for the various components' securityContext values. #41 is an issue open to decide what we should do, running all containers as non root is probably a good idea. I guess user https://github.com/jaegertracing/jaeger/blob/master/cmd/agent/Dockerfile shows that no additional user is created. |
Yes, user |
Alright, I think in this case we should test and then add default securityContext for every pod via the various values helm-charts/charts/jaeger/values.yaml Line 233 in d4042b2
|
When I set |
Great! I think you can get by with just specifying one of the two btw. |
Yes, thanks for the hint. 👍 |
So many of the templates allow specifying |
@haljin I added context for some components in this PR: https://github.com/jaegertracing/helm-charts/pull/37/files |
On another note I think it's time we set runAsNonRoot as default for all components... with say user |
I agree, since most people have to set it anyways (giving them these defaults sounds correct) |
As user 1000 is commonly used, perhaps a more random one would be appropriate. Otherwise, 1000 becomes the new root and breaking the context of a container as user 1000 means potentially access into the other containers running as 1000 and removes the benefit of the not running as root to some degree. |
still no update on this? I'm trying to deploy jaeger AIO with opentelemetry-demo and it does not work on our cluster because it's restriced to only allow non-root users to run containers |
Is this still an issue? jaegertracing/jaeger#2466 was merged 3yrs ago (but only covers the agent) |
Deploying jaeger results in the following error:
Deploy script:
helm upgrade jaeger vendor/jaeger-helm-charts/charts/jaeger \ -n monitoring \ -f vendor/jaeger-helm-charts/charts/jaeger/values.yaml \ -f src/monitoring/jaeger/values.yaml \ -i $@
src/monitoring/jaeger/values.yaml
:We do have a default psp policy in place and its bound to the deployed jaeger pods:
Full description from agent pod:
The text was updated successfully, but these errors were encountered: