Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add toleration to cassandra-schema-job manifest file #546

Open
araamini opened this issue Mar 26, 2024 · 1 comment
Open

[Feature]: Add toleration to cassandra-schema-job manifest file #546

araamini opened this issue Mar 26, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@araamini
Copy link

Requirement

For specific taint and toleration added to cassandra-schema-job.yaml file, it can be passed through values.yaml file.

Problem

There is no any option for specific toleration settings of cassandra-schema-job

Proposal

add the following lines to cassandra-schema-job.yaml

{{- with .Values.schema.tolerations }}
  tolerations:
    {{- toYaml . | nindent 8 }}
{{- end }}

Open questions

No response

@araamini araamini added the enhancement New feature or request label Mar 26, 2024
@tigroo
Copy link

tigroo commented Aug 27, 2024

Hi everybody,
I'm blocked on this lack too (and it's a classic way to pilot all the Kubernetes nodes using taints).
I think it could be great to enhance nodeSelector, affinity and tolerations on the same way the collector e.g.:

      nodeSelector:
        {{- toYaml . | nindent 8 }}
      {{- end }}
    {{- with .Values.collector.affinity }}
      affinity:
        {{- toYaml . | nindent 8 }}
    {{- end }}
    {{- with .Values.collector.tolerations }}
      tolerations:
        {{- toYaml . | nindent 8 }}`
    {{- end }}

There: https://github.com/jaegertracing/helm-charts/blob/26e64394225377dd2cf814e4a21f3477b46c30c6/charts/jaeger/templates/collector-deploy.yaml#L203C1-L213C36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants