Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Ability to set metrics port #611

Open
miroslavmasaryk3221 opened this issue Oct 25, 2024 · 0 comments
Open

[Feature]: Ability to set metrics port #611

miroslavmasaryk3221 opened this issue Oct 25, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@miroslavmasaryk3221
Copy link

miroslavmasaryk3221 commented Oct 25, 2024

Requirement

Requirement
As a jaeger helm chart user, I would like to change exporter port with name admin for all microservices e.g agent to a custom one

Problem

In our environment we need to change it to 9100 for telegraf, because of specific usecase, telegraf config cannot be adopted.
So solution would be to change admin port and also adjust exporter configuration.

For exporter configuration I guess this needs to be changed inside of the image so that it can be then changed as value in values.yaml

ports:
- name: zipkin-compact
  containerPort: {{ .Values.agent.service.zipkinThriftPort }}
  protocol: UDP
  {{- if .Values.agent.daemonset.useHostPort }}
  hostPort: {{ .Values.agent.service.zipkinThriftPort }}
  {{- end }}
- name: jaeger-compact
  containerPort: {{ .Values.agent.service.compactPort }}
  protocol: UDP
  {{- if .Values.agent.daemonset.useHostPort }}
  hostPort: {{ .Values.agent.service.compactPort }}
  {{- end }}
- name: jaeger-binary
  containerPort: {{ .Values.agent.service.binaryPort }}
  protocol: UDP
  {{- if .Values.agent.daemonset.useHostPort }}
  hostPort: {{ .Values.agent.service.binaryPort }}
  {{- end }}
- name: http
  containerPort: {{ .Values.agent.service.samplingPort }}
  protocol: TCP
  {{- if .Values.agent.daemonset.useHostPort }}
  hostPort: {{ .Values.agent.service.samplingPort }}
  {{- end }}
- name: admin
  # here this should be changed 
  containerPort: 14271
  protocol: TCP

Proposal

Example for agent

ports:
- name: zipkin-compact
  containerPort: {{ .Values.agent.service.zipkinThriftPort }}
  protocol: UDP
  {{- if .Values.agent.daemonset.useHostPort }}
  hostPort: {{ .Values.agent.service.zipkinThriftPort }}
  {{- end }}
- name: jaeger-compact
  containerPort: {{ .Values.agent.service.compactPort }}
  protocol: UDP
  {{- if .Values.agent.daemonset.useHostPort }}
  hostPort: {{ .Values.agent.service.compactPort }}
  {{- end }}
- name: jaeger-binary
  containerPort: {{ .Values.agent.service.binaryPort }}
  protocol: UDP
  {{- if .Values.agent.daemonset.useHostPort }}
  hostPort: {{ .Values.agent.service.binaryPort }}
  {{- end }}
- name: http
  containerPort: {{ .Values.agent.service.samplingPort }}
  protocol: TCP
  {{- if .Values.agent.daemonset.useHostPort }}
  hostPort: {{ .Values.agent.service.samplingPort }}
  {{- end }}
- name: admin
  # here this should be changed 
  containerPort: {{ .Values.agent.service.metricsPort }}
  protocol: TCP

Open questions

Nothing

@miroslavmasaryk3221 miroslavmasaryk3221 added the enhancement New feature or request label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant