Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Second Finish for span #147

Closed
DavitSo opened this issue Jan 21, 2019 · 4 comments
Closed

Second Finish for span #147

DavitSo opened this issue Jan 21, 2019 · 4 comments

Comments

@DavitSo
Copy link

DavitSo commented Jan 21, 2019

I it problem to call Finish for finished span or it's just done for performance?
if (isFinished()) {
// Already finished, so return immediately.
return;
}
Actually I want to align root span time in jaeger UI. Is there any other way except call Finish()??

Thanks.

@DavitSo
Copy link
Author

DavitSo commented Jan 21, 2019

finish

@DavitSo
Copy link
Author

DavitSo commented Jan 21, 2019

its permitted to create child span with finished span. And according to documentation child span's time must be bounded with parent span time.

@yurishkuro
Copy link
Member

This is the result of UI adjustment to correct clock skew. Needs a fix for this: jaegertracing/jaeger-ui#197

@DavitSo
Copy link
Author

DavitSo commented Jan 22, 2019

Ok. Thanks.
Although it's opposite to documentation of child, it's useful to see actual time visualization.
So I close issue. @yurishkuro If it's needed feel free to open.

@DavitSo DavitSo closed this as completed Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants