Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

go get does not work due to broken dependency #292

Closed
lebovski opened this issue Apr 23, 2018 · 9 comments
Closed

go get does not work due to broken dependency #292

lebovski opened this issue Apr 23, 2018 · 9 comments

Comments

@lebovski
Copy link

Unfortunately master of jaeger-client-go is broken because of the last commit which doesn't work properly with go.uuid

# github.com/uber/jaeger-client-go
../../../github.com/uber/jaeger-client-go/tracer.go:157:22: multiple-value uuid.NewV4() in single-value context
@yurishkuro
Copy link
Member

Are you using dependency manager? Our master build is green.

@yurishkuro
Copy link
Member

cc @black-adder

@lebovski
Copy link
Author

We do not use dependency manager, we use library that uses jaeger-client-go without manager's config, so we get jaeger-client-go through go get lib/... and it fails.

@isaachier
Copy link
Contributor

How do you get any of the dependencies of jaeger-client-go without a package manager?

@isaachier
Copy link
Contributor

isaachier commented Apr 23, 2018

The go.uuid master has a breaking change. See https://github.com/satori/go.uuid/tree/v1.2.0 vs. https://github.com/satori/go.uuid/tree/master.

@yurishkuro
Copy link
Member

I hope it's not going to be released as 1.x and break semver.

@black-adder do we really need dependency on uuid?

@isaachier
Copy link
Contributor

We don't have a need for the package TBH it just looks nicer that a random number but both will work for throttling.

@isaachier
Copy link
Contributor

isaachier commented Apr 23, 2018

See satori/go.uuid#66 about breaking change.

@lebovski
Copy link
Author

Thank you, all the dependencies we pull manually. We decided to use glide.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants