Could not compile with newest github.com/prometheus/client_golang/prometheus

[laodouya]

# github.com/uber/jaeger-lib/metrics/prometheus ../../../github.com/uber/jaeger-lib/metrics/prometheus/factory.go:143:12: cannot use hv.WithLabelValues(f.tagsAsLabelValues(labelNames, tags)...) (type prometheus.Observer) as type prometheus.Histogram in field value: prometheus.Observer does not implement prometheus.Histogram (missing Collect method)

[laodouya]

It seems this project still use 0.8.0(a year and four months ago) version of github.com/prometheus/client_golang/prometheus

[black-adder]

This repo depends on https://github.com/uber-go/tally which has pinned the older version of prometheus. Once uber-go/tally#42 is resolved, we can go ahead and support newer versions of prometheus, however we'd still somehow have to maintain backwards compatibility.

[yurishkuro]

0.8.0 is the latest official release (https://github.com/prometheus/client_golang/releases), so I don't see a problem here.

[painhardcore]

Same here:

vendor/github.com/uber/jaeger-lib/metrics/prometheus/factory.go:143:12: cannot use hv.WithLabelValues(f.tagsAsLabelValues(labelNames, tags)...) (type prometheus.Observer) as type prometheus.Histogram in field value:
        prometheus.Observer does not implement prometheus.Histogram (missing Collect method)

I'm using
[[constraint]]
branch = "master"
name = "github.com/prometheus/client_golang"

[nickjackson]

@beorn7 mentions over here that they "aim to keep tip of master branch always stable" as appose to relying on tags while its still pre v1.

I guess this is just one of those awkward stages where different people (rightly) have differing ideas about how and when to release software.

[beorn7]

More explanation about the tagging/releasing/stable state of prometheus/client_golang has been added to the README.md here: https://github.com/prometheus/client_golang#important-note-about-releases-versioning-tagging-stability-and-your-favorite-go-dependency-management-tool

[pavelnikolov]

#42 solved this issue

[yurishkuro]

Thanks @pavelnikolov