Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support histograms #62

Closed
yurishkuro opened this issue Nov 20, 2018 · 0 comments
Closed

Support histograms #62

yurishkuro opened this issue Nov 20, 2018 · 0 comments

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Nov 20, 2018

Requirement - what kind of business use case are you trying to solve?

We've had situations where it would be useful to report histograms of non-timer values, e.g. a distribution of queue lengths, or the span sizes. Backends like Prometheus do support them.

Problem - what in Jaeger blocks you from solving the requirement?

The current metrics.Factory only allows timers that are internally implemented as histograms.

Proposal - what do you suggest to solve the problem or improve the existing situation?

  • Replace Factory.Timer() with Factory.Histogram(HistogramOptions{Name, Tags, Description, Buckets})
  • Add static factory methods metrics.Timer(TimeOptions{HistogramOptions, Factory})

Any open questions to address

  • Breaking change, may want to include in 2.x (Define 2.0 release #47)
  • Decide if we want to use structs for arguments, to ensure better extensibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant