Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show running version in UI #365

Closed
hwinkel opened this issue May 5, 2017 · 9 comments
Closed

Show running version in UI #365

hwinkel opened this issue May 5, 2017 · 9 comments

Comments

@hwinkel
Copy link

hwinkel commented May 5, 2017

Is there a way to show the actual version (or git hash before release) (UI, Server) in the UI ?

@yurishkuro
Copy link
Member

Do you mean git hash of your own microservices? Yes, it's possible. When the microservice instantiates Jaeger tracer, it can set tracer tags which will be shown in all spans under Process in the UI. For example, jaeger automatically captures its own library version and the host name as those Process tags. You can also add your microservice version / hash.

screen shot 2017-05-05 at 1 37 22 pm

@hwinkel
Copy link
Author

hwinkel commented Jul 18, 2017

nice to know, but i meant to show the Jaeger Version self.

@tiffon
Copy link
Member

tiffon commented Nov 28, 2017

We can expand #113 to include the version or SHA of Jaeger services.

@yurishkuro What do you think?

@yurishkuro
Copy link
Member

just the sha of the query service.

@jpkrohling jpkrohling transferred this issue from jaegertracing/jaeger Apr 2, 2019
@jan25
Copy link

jan25 commented May 5, 2019

Is this still a valid issue? If no one is working on this, i could pick this up

@tiffon
Copy link
Member

tiffon commented May 6, 2019

@jan25 This is still a valid issue, and it would be awesome if you could pick it up!

For now, the version of the UI is available to JS, but it is not displayed anywhere. Maybe as a footer on the sear h page would work? Open to other approaches, too!

The version of jaeger-query would need to be injected, by jaeger-query, before it is available to JS. Similar to the base path. So that's a bit of work that needs to be done in jaeger core.

@jan25
Copy link

jan25 commented May 10, 2019

@tiffon Footer would be a good idea. What do you think about putting it under 'About Jaeger' dropdown?
Or i was also thinking about a tiny badge near 'Jaeger UI' title in nav bar, it would show UI version and when you hover over badge the tiny tooltip may show the jaeger-query version.

I found a way to inject jaeger-query version from StaticFileHandler on server side. We are currently using regex replace to inject stuff into index.html from there. Would you know if there are better ways to inject data from Go into html?

@alanisaac
Copy link
Contributor

alanisaac commented Jul 28, 2020

I recently ran into this issue, struggling to figure out what version of the UI I had running without digging into my infrastructure / deployment. I took a quick stab at implementing the suggestion to put the UI version in the "About Jaeger" dropdown, and opened #606.

I'm more than happy to play around with other ideas, and / or continue on with trying to enhance it with the commit hash or jaeger-query version.

@yurishkuro
Copy link
Member

Resolved by #606.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants