Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UNSAFE lifecyle methods from React components #374

Closed
tiffon opened this issue Apr 28, 2019 · 2 comments
Closed

Remove UNSAFE lifecyle methods from React components #374

tiffon opened this issue Apr 28, 2019 · 2 comments

Comments

@tiffon
Copy link
Member

tiffon commented Apr 28, 2019

Requirement - what kind of business use case are you trying to solve?

Remain compatible with React upgrades.

Problem - what in Jaeger blocks you from solving the requirement?

Some code needs to be changed. See the UNSAFE_* methods in The Component Lifecycle.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Do not use the unsafe methods.

@tklever
Copy link
Contributor

tklever commented Aug 17, 2020

By my check, branch master no longer has any component methods of componentWillMount, componentWillUpdate, or componentWillReceiveProps or with an UNSAFE_ prefix.

I think this issue is safe to close.

@yurishkuro
Copy link
Member

Thanks @tklever , that's great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants