-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Trace JSON"/"Trace JSON (unadjusted)" open outside Jaeger UI application #680
Comments
Sorry, I don't fully follow what is being proposed. Are you suggesting a dedicated component to manually render JSON without leaving the UI? Currently View JSON buttons double as a means to download the trace JSON, not only view it. |
Correct! I suggest a custom component for render/download raw traces. The reason for that is once you open "Trace JSON" its go out of UI app control and fire direct API query, which is under control of iframe in our case... 😞 |
I think we may already have some form of JSON rendering for tag values, so perhaps it's not too bad to implement it for full trace JSON. The only concern I have is to make sure that the component scales up for very large traces, since the current method just relies on the browser file rendering with minimal overhead. |
What is the max size of trace have you face? BTW, you have mentioned |
|
@yurishkuro |
Sorry I don't have examples, it was with Uber's production data. Do you mean the size in bytes? For 100,000 spans it would be 50-100Mb. |
Hi @yurishkuro :)
WDYT? |
This ticket looks like a duplicate of #1211, which has an in-progress PR solving it. @nofar9792 As for your specific suggestions:
|
Requirement - what kind of business use case are you trying to solve?
"Trace JSON"/"Trace JSON (unadjusted)" open outside Jaeger UI application. For this case, we have no ability to manage auth tokens in HTTP headers via iframe
Problem - what in Jaeger blocks you from solving the requirement?
"Trace JSON"/"Trace JSON (unadjusted)" use a direct API call to get JSON from the backend. No ability to handle HTTP headers
Proposal - what do you suggest to solve the problem or improve the existing situation?
The solution is to create a react component, which makes a call to the backend via JaegerAPI. Also, this component can deprecate "Trace JSON (unadjusted)" in the trace page's dropdown. This functionality can be performed by these components. Also, we can make some progress here #197
The text was updated successfully, but these errors were encountered: