Fix span links for leading 0s trace ID #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Everett Ross <reverett@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #539 +/- ##
==========================================
- Coverage 92.97% 92.95% -0.03%
==========================================
Files 197 197
Lines 4840 4840
Branches 1174 1174
==========================================
- Hits 4500 4499 -1
- Misses 300 301 +1
Partials 40 40
Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Mar 6, 2020
| @@ -208,7 +208,7 @@ export class UnconnectedSearchResults extends React.PureComponent<SearchResultsP | |||
| linkTo={getLocation( | |||
| trace.traceID, | |||
| { fromSearch: searchUrl }, | |||
| spanLinks && spanLinks[trace.traceID] | |||
| spanLinks && (spanLinks[trace.traceID] || spanLinks[trace.traceID.replace(/^0*/, '')]) | |||
There was a problem hiding this comment.
I suggest adding a unit test for this use case.
Fix lookback test issue with dst Signed-off-by: Everett Ross <reverett@uber.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
* Fix span links for leading 0s trace ID * Add tests for deep linking leading 0s Fix lookback test issue with dst Signed-off-by: Everett Ross <reverett@uber.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
?span=${id}@${traceID}fetches a trace such that:the deep linking would not be passed on.
Short description of the changes
trace.traceIDwith leading 0s stripped out iftrace.traceIDis not present inspanLinks