Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the service dropdown list in jaeger UI #1114

Open
clyang82 opened this issue Oct 12, 2018 · 3 comments
Open

Limit the service dropdown list in jaeger UI #1114

clyang82 opened this issue Oct 12, 2018 · 3 comments

Comments

@clyang82
Copy link
Contributor

clyang82 commented Oct 12, 2018

Requirement - what kind of business use case are you trying to solve?

There has service list page in our portal. We want to integrate jaeger ui when click the certain service to show the tracing for this service only. Right now, the service dropdown lists all available services. We want to pass a parameter together with service to show this service only in dropdown list.

Problem - what in Jaeger blocks you from solving the requirement?

Without this feature, the user can see all available services which is not our expectation.

Proposal - what do you suggest to solve the problem or improve the existing situation?

provide a parameter - limited=true to limit the service dropdown to display this service only.
the url pattern is ?service=xxx&limited=true

Pass this parameter to SearchForm to implement this goal.

<Field
            name="service"
            component={AdaptedVirtualSelect}
            placeholder="Select A Service"
            props={{
              disabled: limited,
              clearable: false,
              options: services.map(v => ({ label: v.name, value: v.name })),
              required: true,
            }}
 />

@yurishkuro
Copy link
Member

Could you please explain what you're trying to achieve by hiding the other services in the drop-down? This cannot be for security reasons since the user can simply remove the parameters from the URL and go back to the full list.

Also, do you mind adding yourself to #207 ?

@clyang82
Copy link
Contributor Author

I am able to embed the jaeger ui into our portal by using Iframe so that the end user cannot see the real URL. Except for using debug tools or other ways to check the url, that is different thing.

I am doing evaluation right now. I will add myself to that issue once we put jaeger into production. Thanks.

@clyang82
Copy link
Contributor Author

This issue can be closed when this pr is merged into master.
jaegertracing/jaeger-ui#263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants