Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move /metrics from the query port to internal (health-check) #1332

Closed
jpkrohling opened this issue Feb 12, 2019 · 2 comments · Fixed by #1442
Closed

Move /metrics from the query port to internal (health-check) #1332

jpkrohling opened this issue Feb 12, 2019 · 2 comments · Fixed by #1442

Comments

@jpkrohling
Copy link
Contributor

Problem - what in Jaeger blocks you from solving the requirement?

Jaeger currently exposes the metrics via the main query endpoint, which might be exposed to the public internet. Ideally, the /metrics endpoint would be directed to the internal, admin-only port that is used by the health-check handler.

$ docker run -p 16686:16686 --rm jaegertracing/all-in-one:1.9 
$ curl localhost:16686/metrics 
@objectiser
Copy link
Contributor

+1, although support for the endpoint on the existing port would need to be deprecated so not to break existing deployments.

@yurishkuro
Copy link
Member

support for the endpoint on the existing port would need to be deprecated so not to break existing deployments

This is quite messy to do, I prefer we require a clean cut over to the new port (#1442).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants