Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Adjusters in Query Service configurable #1367

Closed
MichaHoffmann opened this issue Feb 21, 2019 · 4 comments
Closed

Make Adjusters in Query Service configurable #1367

MichaHoffmann opened this issue Feb 21, 2019 · 4 comments

Comments

@MichaHoffmann
Copy link

Requirement - what kind of business use case are you trying to solve?

Asynchronous requests will sometimes lead to wrong rendering of traces because of clock-skew adjustments in the query service. If the root trace is (0ms, 10ms) and an traced action that was started asynchronously is (20ms, 25ms), it will be shifted to be contained in the interval (0ms, 10ms) approximately.

Problem - what in Jaeger blocks you from solving the requirement?

There seems to be no way to configure the Query Service to turn off selected Adjusters. Just commenting the clock-skew adjuster made the traces look much better.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Make the used Adjusters configurable, maybe via cli-flags.

Any open questions to address

Is there a way to configure the adjusters that i have missed?

@black-adder
Copy link
Contributor

black-adder commented Feb 21, 2019

There is a way to disable adjustment in the UI:
image
However this just gives you the json blob and doesn't actually display the trace. Do you mind creating a feature request ticket in the UI repo?

@yurishkuro
Copy link
Member

This is a different issue. I am going to respond shortly.

@yurishkuro
Copy link
Member

@MichaHoffmann please see this issue: #961. Configurable adjusters is one possible solution, but I don't think it's the best one.

@MichaHoffmann
Copy link
Author

Thank you for your response! #961 and jaegertracing/jaeger-ui#197 look like a valid solution to my problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants