Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollover API support listed as experimental, is it safe for production? #2287

Closed
hgrant-ebsco opened this issue Jun 10, 2020 · 5 comments · Fixed by #2290
Closed

Rollover API support listed as experimental, is it safe for production? #2287

hgrant-ebsco opened this issue Jun 10, 2020 · 5 comments · Fixed by #2290

Comments

@hgrant-ebsco
Copy link

We have recently have upgraded our Jaeger deployment to 1.18. As part of the deployment we are looking into using the Elasticsearch rollover feature. We have however noticed that in parts of the documentation, this is marked as experimental. This has brought up concern about using it in a production deployment. Our plan is currently to utilize it based on the max_size option to keep our indices below a specified size. We have a test cron job that runs every 15 min against the AWS manged ES cluster.

Is this feature one that is safe for production deployment? Are there any concerns we should keep in mind because of the experimental label?

@ghost ghost added the needs-triage label Jun 10, 2020
@pavolloffay
Copy link
Member

Rollover is a stable feature. It's safe to be used in a production environment. I will remove the experimental labels from flags.

Where in the docs did you see experimental?

@hgrant-ebsco
Copy link
Author

Rollover is a stable feature. It's safe to be used in a production environment. I will remove the experimental labels from flags.

Where in the docs did you see experimental?

Great to hear that it is stable.

It is listed as experimental in several places on the CLI flags page within the documentation: https://www.jaegertracing.io/docs/1.18/cli/#jaeger-collector as an example.

@pavolloffay
Copy link
Member

It has been removed from the CLI flags. Where else did you see it?

@hgrant-ebsco
Copy link
Author

It has been removed from the CLI flags. Where else did you see it?

Noted here within this text as an example.
https://www.jaegertracing.io/docs/1.18/cli/#jaeger-collector-elasticsearch

--es.use-aliases false
(experimental) Use read and write aliases for indices. Use this option with Elasticsearch rollover API. It requires an external component to create aliases before startup and then performing its management. Note that es.max-span-age is not taken into the account and has to be substituted by external component managing read alias.

@pavolloffay
Copy link
Member

That is derived from flags, It should be fixed now by #2290.

thanks for reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants