Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test: TestHotReloadUIConfigTempFile #2711

Closed
albertteoh opened this issue Jan 4, 2021 · 0 comments · Fixed by #2713
Closed

Flaky test: TestHotReloadUIConfigTempFile #2711

albertteoh opened this issue Jan 4, 2021 · 0 comments · Fixed by #2713
Labels

Comments

@albertteoh
Copy link
Contributor

Describe the bug
The TestHotReloadUIConfigTempFile test appears to fail due to timeout after not detecting the config changes.

To Reproduce
Steps to reproduce the behavior:

  1. go clean -testcache && go test -test.count=50 ./cmd/query/app -v -run TestHotReloadUIConfigTempFile
  2. Resulting failure (note the first succeeds, next attempt fails):
=== RUN   TestHotReloadUIConfigTempFile
--- PASS: TestHotReloadUIConfigTempFile (0.13s)
=== RUN   TestHotReloadUIConfigTempFile
    static_handler_test.go:161: 
                Error Trace:    static_handler_test.go:161
                Error:          timed out waiting for the hot reload to kick in
                Test:           TestHotReloadUIConfigTempFile
--- FAIL: TestHotReloadUIConfigTempFile (1.04s)

Version (please complete the following information):

  • OS: MacOS
  • Jaeger version: master

What troubleshooting steps did you try?
Increasing the wait time to time.After(30 * time.Second) blocks for the entire 30 seconds before failing.

Additional context
Issue was observed while testing PR #2707.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant