Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clockskew.go adjuster should skip FollowsFrom spans #448

Open
black-adder opened this issue Oct 2, 2017 · 6 comments
Open

clockskew.go adjuster should skip FollowsFrom spans #448

black-adder opened this issue Oct 2, 2017 · 6 comments

Comments

@black-adder
Copy link
Contributor

Right now, followsFrom spans are incorrectly clock skew adjusted to fit inside the parent

@bogatuadrian
Copy link

I opened a PR at #460 that tries to fix this issue. I'm not sure if it's the right approach, but I'm up to make any needed changes requested in the review.

@bogatuadrian
Copy link

At least is it possible to add an option to exclude the clock skew adjuster from the list of adjusters at startup? Or, maybe even better, to add that to the API request?

@yurishkuro
Copy link
Member

There is a feature in the query API that we're missing to return the trace without any kind of adjustments, which is especially useful for looking at raw JSON.

@yurishkuro
Copy link
Member

to return the trace without any kind of adjustments

#617

@jpkrohling
Copy link
Contributor

Is this still relevant?

@yurishkuro
Copy link
Member

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants