Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mumble-dark theme icons color #29

Open
stderr-to-devnull opened this issue Oct 19, 2020 · 30 comments
Open

mumble-dark theme icons color #29

stderr-to-devnull opened this issue Oct 19, 2020 · 30 comments

Comments

@stderr-to-devnull
Copy link

After upgrading to qbittorrent 4.3.0 and downloading the new mumble-dark theme, I noticed that almost all icons are now pink. Is this by design? Can the color be modified? Can the actual look of the new theme be reflected in an updated screenshot?

@mzso
Copy link

mzso commented Oct 19, 2020

I think its some bug. I have orange for inactive upload/download and paused as well.
Looks rather bad:
kép

@Hvalfisk
Copy link

The orange stalled up and down arrows are really hard to tell apart.

@mzso
Copy link

mzso commented Oct 19, 2020

Is this issue because of new QBT or the new theme? I upgraded simultaneously.

@jagannatharjun
Copy link
Owner

Can the actual look of the new theme be reflected in an updated screenshot?

what're you saying it's already updated.

Is this issue because of new QBT or the new theme? I upgraded simultaneously.

What's the issue?

@jagannatharjun
Copy link
Owner

I noticed that almost all icons are now pink. Is this by design? Can the color be modified?

yes starting with qbit 4.3.0 icons can be changed from theme files.

@stderr-to-devnull
Copy link
Author

stderr-to-devnull commented Oct 20, 2020

OK so from what I deduced, icon colors were a design choice. The screenshot shows some of the updated color for icons but not all elements (done, uploading, sidebar with trackers list etc) so this is why it appears to look different (the UI in the screenshot is a lot cleaner, meaning one torrent with one status). I would say it no longer looks that good when having all elements in the UI + full list of torrents but this is subjective of course.

yes starting with qbit 4.3.0 icons can be changed from theme files.

Can you help with showing us how to do this?

@mzso
Copy link

mzso commented Oct 20, 2020

Is this issue because of new QBT or the new theme? I upgraded simultaneously.

What's the issue?

Most category/state icons being orange. (See screenshot) In my case anyway. Someone else said it's pink.

@jagannatharjun
Copy link
Owner

jagannatharjun commented Oct 21, 2020

Can you help with showing us how to do this?

  1. Download files from here https://github.com/jagannatharjun/qbt-theme
  2. Download all files from here https://github.com/nowshed-imran/qBittorrent/tree/redo/src/icons and put it in Builds\icons\nowshed
  3. run this https://github.com/jagannatharjun/qbt-theme/blob/master/Builds/build-mumble-dark.bat

this line changes colors https://github.com/jagannatharjun/qbt-theme/blob/master/Builds/build-mumble-dark.bat#L9 Currently it only changes the primary color to pink, you can play with it and you need python installed

@TheArgentinian
Copy link

I really dislike the new icons. Too distracting.

@mzso
Copy link

mzso commented Oct 21, 2020

@TheArgentinian

I really dislike the new icons. Too distracting.

You also get orange icons?
What's annoying is that several different ones are the same color. Which makes no sense design wise, not practical at all...

@jagannatharjun
Copy link
Owner

@TheArgentinian @mzso
try these
new-icons.zip

@TheArgentinian
Copy link

@TheArgentinian

I really dislike the new icons. Too distracting.

You also get orange icons?

Yes

@TheArgentinian @mzso
try these
new-icons.zip

They are still all colored like a rainbow. They should blend with the background, not pop-up, do you know what I mean?

@ArtexJay
Copy link

ArtexJay commented Oct 22, 2020

I'm not a fan of the pinkish default color icon. I'd rather you have used the blue ones you did for breeze-dark/darkstylesheet. Those are better than the pink ones.
Other than that I'm personally ok with colorful icons and I think the Mumble is still one of the best dark themes. Just that pink default color doesn't suit me at all.

Edit: Never mind! Those new themes you posted in that zip had the color change I needed! Now it's back to being great. Thanks

@mzso
Copy link

mzso commented Oct 22, 2020

@TheArgentinian @mzso
try these
new-icons.zip

They are still all colored like a rainbow. They should blend with the background, not pop-up, do you know what I mean?

I don't think so. All differing ones should have a different color. Monochrome/grey nonsense is the worst.

@japanesephundroid
Copy link

@TheArgentinian @mzso
try these
new-icons.zip

They are still all colored like a rainbow. They should blend with the background, not pop-up, do you know what I mean?

I don't think so. All differing ones should have a different color. Monochrome/grey nonsense is the worst.

I agree with this, color icons are easier to differentiate, with colors that can be easily associated with the action.

I liked mumble-dark-nowshed.qbtheme in the new-icons.zip.

@xiao-mantou
Copy link

xiao-mantou commented Oct 23, 2020

Rolling back to V1, everything is fine. #31

@mzso
Copy link

mzso commented Oct 23, 2020

@jagannatharjun commented on 2020. okt. 21. 19:41 CEST:

@TheArgentinian @mzso
try these
new-icons.zip

Thanks!
Much better this way. To be clear, were the colors set to orange for several different icons on purpose, by hand? (or was it some glitch?)
By the way, the difference between recolored and plain "nowshed" (BTW what is "nowshed"? :) ) is that some of the blue colors are replaced with purple? I say some, because scrollbar, stopped torrent color, selected tab is still blue. I actually prefer blue, I find that pale purple a little weird. (To be honest I'd prefer warm colors for dark themes. More natural.)

One idea: Stuck download/upload colors could be a dimmer/less-saturated/darker shade of the normal upload/download colors. So people could associate one color with upload/download, but also immediately tell whether it's active or not.

@jagannatharjun
Copy link
Owner

(BTW what is "nowshed"? :) )

creator of icons, these icons are proposed for the next default icons for qbittorrent, "recolored" icons are recolored ones.

Do give your opinions there too qbittorrent/qBittorrent#12965

@ArtexJay
Copy link

@TheArgentinian @mzso
try these
new-icons.zip

Can you update these files with the fixed progress bar? The newest qbittorrent update messes up the progress bar a bit, it's not centered anymore. as mentioned in #35

@RabidWolf
Copy link

@jagannatharjun

Will the mumble themes, ones with nowshed icons, be updated soon?

@mzso
Copy link

mzso commented Dec 7, 2020

@RabidWolf commented on 2020. dec. 2. 21:37 CET:

@jagannatharjun

Will the mumble themes, ones with nowshed icons, be updated soon?

For heaven's sake. The main version still has identical icon colors.

@ArtexJay
Copy link

@jagannatharjun the superior version for Mumble dark theme that you posted in the zips here, haven't been updated to version 2.1 yet.

@mzso
Copy link

mzso commented Dec 12, 2020

@ArtexJay commented on 2020. dec. 12. 08:49 CET:

@jagannatharjun the superior version for Mumble dark theme that you posted in the zips here, haven't been updated to version 2.1 yet.

Yeah. Updating that would be nice. Or just adding the icon set to Mumble dark proper.

@mzso
Copy link

mzso commented Dec 27, 2020

@jagannatharjun commented on 2020. okt. 21. 07:04 CEST:

Can you help with showing us how to do this?

  1. Download files from here https://github.com/jagannatharjun/qbt-theme
  2. Download all files from here https://github.com/nowshed-imran/qBittorrent/tree/redo/src/icons and put it in Builds\icons\nowshed
  3. run this https://github.com/jagannatharjun/qbt-theme/blob/master/Builds/build-mumble-dark.bat

this line changes colors https://github.com/jagannatharjun/qbt-theme/blob/master/Builds/build-mumble-dark.bat#L9 Currently it only changes the primary color to pink, you can play with it and you need python installed

So this doesn't work at all. I guess it has a bunch of dependencies, that I don't have. (Also it seems finicky about paths. Since it gave different errors at different locations.)

@mzso
Copy link

mzso commented Mar 13, 2021

@jagannatharjun
So, did development on these dark themes effectively cease? The last version with identical colors for most icons I find poorly usable. And the one with the updated icons shared here still have visual glitches on the progress bar.

@jagannatharjun
Copy link
Owner

did development on these dark themes effectively cease?

hmm, maybe yes, I personally liked the current themes and I neither have the time nor any kind of motivation to change it. progress bar text should be fixed in the current master. though you have to compile the files yourself.

@mzso
Copy link

mzso commented Mar 14, 2021

@jagannatharjun commented on 2021. márc. 13. 18:33 CET:

did development on these dark themes effectively cease?

hmm, maybe yes, I personally liked the current themes and I neither have the time nor any kind of motivation to change it. progress bar text should be fixed in the current master. though you have to compile the files yourself.

I don't know how to compile it though.
Though the PB is fixed in the previous version as well, but that doesn't have the updated icons. Are you implying that since then the icons were updated as well?
(Github seems to fail to send comments much of the time... I made this one yesterday. Yet it was still here unsent now...)

@jagannatharjun
Copy link
Owner

check https://github.com/jagannatharjun/qbt-theme/blob/master/mumble-dark-nowshed.qbtheme for no pink icons

@mzso
Copy link

mzso commented Sep 18, 2021

@jagannatharjun commented on 2021. szept. 18. 11:46 CEST:

check https://github.com/jagannatharjun/qbt-theme/blob/master/mumble-dark-nowshed.qbtheme for no pink icons

Thanks, though it doesn't help with my problem. All this orange instead of the separately colored categories of the older (and now glitched) variant you shared before is not very practical.
qb-theme

@jagannatharjun
Copy link
Owner

@mzso you can give your opinion qbittorrent/qBittorrent#15453, the icon set will be default for qbittorrent 4.4.0+ release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants