Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write down the rules for interceptors in CDI Lite #545

Closed
Ladicek opened this issue Oct 20, 2021 · 2 comments · Fixed by #548
Closed

write down the rules for interceptors in CDI Lite #545

Ladicek opened this issue Oct 20, 2021 · 2 comments · Fixed by #548
Assignees
Labels
Lite Related to CDI Lite

Comments

@Ladicek
Copy link
Contributor

Ladicek commented Oct 20, 2021

We verbally agreed that we want to narrow down how interceptors may be declared and bound in CDI Lite. We need to write it down to the spec.

A big part of the discussion happened in this issue: jakartaee/cdi-tck#262 I'm copying the table that we agreed upon:

✔️ means "part of CDI Lite"
❌ means "not part of CDI Lite, only CDI Full"
❔ means "I don't know, please help" :-)
☣️ means "can't happen"

@AroundConstruct @PostConstruct, @PreDestroy @AroundInvoke
On target class ☣️ ✔️
On interceptor class, binding annotation + @Priority ✔️ ✔️ ✔️
On interceptor class, @Interceptors
On interceptor class, enabled using beans.xml
Implementing Interceptor
Using InterceptionFactory ☣️ ☣️

I'm leaving @AroundInvoke on target class as ❔, but all things considered, it should really be ❌.

@Ladicek Ladicek added the Lite Related to CDI Lite label Oct 20, 2021
@Emily-Jiang
Copy link
Contributor

Looks good!

@graemerocher
Copy link
Contributor

+1 from me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lite Related to CDI Lite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants