Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enabled beans link in CDI Full #667

Closed
jeanouii opened this issue Apr 25, 2023 · 2 comments · Fixed by #670
Closed

Fix enabled beans link in CDI Full #667

jeanouii opened this issue Apr 25, 2023 · 2 comments · Fixed by #670
Assignees
Milestone

Comments

@jeanouii
Copy link

We discussed it, and I think @Ladicek fixed it, but in case we have done, opening this issue, to make sure we do it and it appears in the release notes.

In section https://jakarta.ee/specifications/cdi/4.0/jakarta-cdi-spec-4.0.html#bean_discovery_steps_full the bullet list links to <> but the link is actually wrong because there is another section for enabled beans in CDI Full mode.

So there is a mismatch. If you strictly read and follow the link, enabled beans do not take Specialized beans into account. The TCK is currently testing them and there is a definition in the document to amend the enabled beans definition in the context of CDI Full.

@jeanouii
Copy link
Author

I'm even wondering why there is a different rule for enabled beans in the CDI Full context to be honest.
For instance, from a user point of view, it would be easier to understand if we would always fire PBA for all beans (without all the specialization boiler plate). There won't be a PB afterward, when we have all the bean set and mutated attributes or vetoed beans.

@Ladicek
Copy link
Contributor

Ladicek commented Apr 25, 2023

I actually found that I only have the fix in my local checkout of the repo, I didn't submit a PR yet. Thanks for the reminder! :-)

When it comes to event ordering, I guess that would fall under #666?

@Ladicek Ladicek added this to the CDI 4.1/5.0 milestone Apr 25, 2023
@Ladicek Ladicek self-assigned this Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants