Committer Conventions

Committer Conventions

The committers of this project agreed upon the following conventions.

Minimum Length of review period before merge / close of PRs and closing of Issues

Default review period is two weeks. The assignee of a PR may decide to reduce review period if API is unchanged, but it must never be shorter than one week.

Self-Assigned PRs and Issues

A committer may self-assign and merge / close PRs and Issues opened by himself.

Self-Reviewed PRs and Issues

Due to Github platform restrictions, a committer technically cannot review PRs opened by himself. Due to that, one implied +1 review vote is assumed for all PRs and Issues opened by committers.

Enforcing Github reviews

PR reviews happen using the Github PR Review tool. The platform will technically enforce a minimum of +2, but a PR is assumed to be accepted only when having +3 or more committer votes. Contributor votes are not counted.