Upgrade guzzle in composer.json #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jakubkulhan Hi, could you review this PR? Looks fine to me |
|
@jakubkulhan just trying to bump this, could you please review this PR? |
|
we should maintain support for Guzzle v6 so that consumers aren't forced to upgrade if they don't need v7. I would recommended changing this to match ejunker's suggestion in #27, i.e. |
|
I'm also running into this issue with a package (Sage Intacct, or intacct/intacct-sdk-php) requiring a later version of Guzzle. Could this be merged? |
|
I've created a PR which does not force consumers to upgrade to v7 if they don't want to. #33 |
|
I've merged #33 instead. Thank you for your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Laravel 8 requires guzzle to be set at
^7.0.1.chrome-devtools-protocolsets guzzle at6.3. Upon testing it thoroughly there appears to be no impact upgrading guzzle to^7.0.