From 2a5e06c5337a0f9bf370d566f91fbb7ce1a17be8 Mon Sep 17 00:00:00 2001 From: Jakob Hellermann Date: Tue, 9 Aug 2022 16:53:28 +0000 Subject: [PATCH] add some info from `ReflectPathError` to the error messages (#5626) # Objective - The `Display` impl for `ReflectPathError` is pretty unspecific (e.g. `the current struct doesn't have a field with the given name` - it has info for better messages available ## Solution - make the display impl more descriptive by including values from the type --- crates/bevy_reflect/src/path.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/crates/bevy_reflect/src/path.rs b/crates/bevy_reflect/src/path.rs index 2b749d2efa0800..e749f0d4c247d0 100644 --- a/crates/bevy_reflect/src/path.rs +++ b/crates/bevy_reflect/src/path.rs @@ -6,20 +6,20 @@ use thiserror::Error; /// An error returned from a failed path string query. #[derive(Debug, PartialEq, Eq, Error)] pub enum ReflectPathError<'a> { - #[error("expected an identifier at the given index")] + #[error("expected an identifier at index {index}")] ExpectedIdent { index: usize }, - #[error("the current struct doesn't have a field with the given name")] + #[error("the current struct doesn't have a field with the name `{field}`")] InvalidField { index: usize, field: &'a str }, - #[error("the current tuple struct doesn't have a field with the given index")] + #[error("the current tuple struct doesn't have a field with the index {tuple_struct_index}")] InvalidTupleStructIndex { index: usize, tuple_struct_index: usize, }, - #[error("the current list doesn't have a value at the given index")] + #[error("the current list doesn't have a value at the index {list_index}")] InvalidListIndex { index: usize, list_index: usize }, - #[error("encountered an unexpected token")] + #[error("encountered an unexpected token `{token}`")] UnexpectedToken { index: usize, token: &'a str }, - #[error("expected a token, but it wasn't there.")] + #[error("expected token `{token}`, but it wasn't there.")] ExpectedToken { index: usize, token: &'a str }, #[error("expected a struct, but found a different reflect value")] ExpectedStruct { index: usize },