Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

t helper is broken with glimmer (1.13 compatibility) #237

Closed
blimmer opened this issue Jun 14, 2015 · 2 comments
Closed

t helper is broken with glimmer (1.13 compatibility) #237

blimmer opened this issue Jun 14, 2015 · 2 comments

Comments

@blimmer
Copy link
Contributor

blimmer commented Jun 14, 2015

The helper.js implementation appears to be incompatible with the newly released Ember 1.13 helpers.

There are several errors associated with these changes, it seems:

  1. Container moved in environment
    This patch fixes this part:
export default function t(params, hash, options, env) {
  const container = env.data ? env.data.view.container : env.container;
  const i18n = container.lookup('service:i18n');
  1. Structure of stream appears to have changed
    The output from the helper appears to be [Object object] once the container lookup passes.

Supposedly 1.13 supports non-dasherized helpers, so perhaps the hack to register the helper in the initializer is no longer needed (this would be great for testing).

@blimmer blimmer changed the title t helper is broken with glimmer t helper is broken with glimmer (1.13 compatibility) Jun 14, 2015
@jamesarosen
Copy link
Owner

See #227, which is waiting for emberjs/ember.js#11445

@blimmer
Copy link
Contributor Author

blimmer commented Jun 15, 2015

Thanks for the update!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants