Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out AUR packaging with Node SEA #71

Closed
jannis-baum opened this issue Jul 11, 2024 · 8 comments
Closed

Figure out AUR packaging with Node SEA #71

jannis-baum opened this issue Jul 11, 2024 · 8 comments
Assignees

Comments

@jannis-baum
Copy link
Owner

jannis-baum commented Jul 11, 2024

Based on discussion in #68

@tuurep
Copy link
Collaborator

tuurep commented Jul 11, 2024

What I'm planning to do next:

  1. Set up vivify-bin in AUR that gets the current precompiled release (0.1.6)
  2. When we release, bump version number on that and see that it still works
  3. Mark vivify (AUR) as Out-of-date with a comment about the segfault issue in Node SEA

@tuurep
Copy link
Collaborator

tuurep commented Jul 11, 2024

Btw I'm noticing in some AUR PKGBUILDs that instead of zip or unzip, they typically use bsdtar to work with .zip files

In case that could be used in make linux, noting this here!

@tuurep
Copy link
Collaborator

tuurep commented Jul 11, 2024

Ok, vivify-bin for version 0.1.6 works:

https://aur.archlinux.org/packages/vivify-bin

@jannis-baum
Copy link
Owner Author

jannis-baum commented Jul 12, 2024

Btw I'm noticing in some AUR PKGBUILDs that instead of zip or unzip, they typically use bsdtar to work with .zip files

In case that could be used in make linux, noting this here!

Ah nice, and bsdtar is a program that is available on Arch by default? I swapped it out in #77, seems like it works :)

EDIT Nevermind, the GitHub Ubuntu CI doesn't have bsdtar installed so I would not use it :(

EDIT 2 I never realized that tar can also zip; I switched to tar now, this works, also on the CI.

@jannis-baum
Copy link
Owner Author

jannis-baum commented Jul 12, 2024

Ok, vivify-bin for version 0.1.6 works:

https://aur.archlinux.org/packages/vivify-bin

Great! So I assume that should mean that newer versions will also work?

Feel free to close this issue if everything is cleared up then :)

@tuurep
Copy link
Collaborator

tuurep commented Jul 12, 2024

Yeah, I wasn't sure if bsdtar default was just an Arch thing or more common, but that clears that up :)

Check my comment on #77 I have big doubts that tar is used properly

Great! So I assume that should mean that newer versions will also work?

We'll find out but yes it looks like vivify-bin is good, but vivify will now break

You can release whenever you feel like it and I'll update the packages 😄

@jannis-baum
Copy link
Owner Author

Alright! I was thinking to wait to merge all the currently open PRs (except for maybe the one about the tar thing) and then release v0.2.0 :)


Going to close this now then, we can keep talking about the tar thing on that PR

@tuurep
Copy link
Collaborator

tuurep commented Jul 21, 2024

All AUR packaging is working!

But gives me a thought about make install:

If I want to use make install in my PKGBUILD, I'd do like this:

./configure "${pkgdir}/usr/bin"
make install

But currently that doesn't work if the install dir doesn't already exist

This does, of course:

mkdir -p "${pkgdir}/usr/bin"
./configure "${pkgdir}/usr/bin"
make install

(don't worry about what "${pkgdir}" is, that's an AUR thing and unimportant)

So should make install actually be the one who does a mkdir -p first? What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants