-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importing keyring takes long time on WSL2 #531
Comments
Please try keyring ≥ 21.6.0 where #480 was merged. |
After |
doesn't that just hide/delay the symptoms though? I'm not sure about the specific implementation but wouldn't a keyring service like GNOME keyring be available in Ubuntu in WSL? In which case attempting to read from it would cause either hanging or crashes as observed in yt-dlp/yt-dlp#551 |
Yes, the symptom is delayed. |
What backend are you going to use on WSL2? If it's SecretService backend, then you need to set up the server, for example as described in README: If it is a different backend, I suggest you to specify it explicitly in the configuration file: |
so it sounds like for a user who doesn't know about keyring (and therefore has not configured it) and wants to use a tool which uses keyring (like yt-dlp) then either:
So as a mitigation, yt-dlp can import keyring on demand and hopefully not too many users will require keyring access in WSL, but for those that do, would it be possible to have better detection of this problem on the keyring side so that users are more informed about the problem rather than assuming that the tool they are using has a problem? For example, perhaps if WSL is detected (using this), then set a short dbus timeout if possible to something like 5 seconds and catch |
Describe the bug
When
import keyring
on WSL2, it hangs for long time (about 6-8 minutes on my PC)Note that this symptom only happens when
DISPLAY
variable is set in WSL2 but no X-server is running on Windows.If
ctrl+c
then log shows that the issue is related to dbus:There are two work-arounds I have found:
unset DISPLAY
or
Any of them can work-around this symptom.
To Reproduce
Steps to reproduce the behavior:
Enter the following commands on WSL2
Expected behavior
It should not take long time.
Environment
Python 3.8.10
Additional context
Please refer to yt-dlp/yt-dlp#551 for more discussion history.
The text was updated successfully, but these errors were encountered: