[with-typescript] Server HMR fails when entry file is .ts

[markyfyi]

Hey, great work on razzle! I've developing on top of latest with-typescript, and noticed HMR on the server is broken.

Steps to repro:

1. create-razzle-app --example with-typescript <name>
2. cd <name>
3. npm start
4. Edit and save src/server.tsx
5. Dev server output:

[HMR] Cannot apply update.
[HMR] Error: Aborted because ./src/index.ts is not accepted
Update propagation: ./src/index.ts -> 0
    at hotApply (<...>/razzle-ts-hmr-demo/build/server.js:400:30)
    at <...>/razzle-ts-hmr-demo/build/server.js:249:21
    at <anonymous>
[HMR] You need to restart the application!

If you convert src/index.ts to .js, HMR works again. 🤔 (demo: https://github.com/markshlick/razzle-ts-hmr-demo/commit/dc476fdc3ba03a1b018b1f783dd3a0aea556fe1a).

[eronalves]

+1

[Thomas-X]

+1

[rayandrew]

have you tried the new razzle typescript plugin?

[pavelprokes]

+1

[SheikhG1900]

Problem is in index.ts file. I changed its code with following. (Razzle default index.js code). Now server HMR working.

import http from 'http'
import app from './server'

const server = http.createServer(app)

let currentApp = app

server.listen(process.env.PORT || 3000, (error) => {
  if (error) {
    console.log(error)
  }

  console.log('🚀 started')
})

if (module.hot) {
  console.log('✅  Server-side HMR Enabled!')

  module.hot.accept('./server', () => {
    console.log('🔁  HMR Reloading `./server`...')
    server.removeListener('request', currentApp)
    const newApp = require('./server').default
    server.on('request', newApp)
    currentApp = newApp
  })
}

[stale]

Hola! So here's the deal, between open source and my day job and life and what not, I have a lot to manage, so I use a GitHub bot to automate a few things here and there. This particular GitHub bot is going to mark this as stale because it has not had recent activity for a while. It will be closed if no further activity occurs in a few days. Do not take this personally--seriously--this is a completely automated action. If this is a mistake, just make a comment, DM me, send a carrier pidgeon, or a smoke signal.

[stale]

ProBot automatically closed this due to inactivity. Holler if this is a mistake, and we'll re-open it.