-
-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples/with-typescript gives ~300 lines of type errors on default install #666
Comments
... (the end of error was snipped away but here it is) ... TS2320: Interface 'IntrinsicClassAttributes' cannot simultaneously extend types 'ClassAttributes' and 'ClassAttributes'. |
Problem seems to be related somehow to yarn workspaces and yarn.lock -file.
|
Hola! So here's the deal, between open source and my day job and life and what not, I have a lot to manage, so I use a GitHub bot to automate a few things here and there. This particular GitHub bot is going to mark this as stale because it has not had recent activity for a while. It will be closed if no further activity occurs in a few days. Do not take this personally--seriously--this is a completely automated action. If this is a mistake, just make a comment, DM me, send a carrier pidgeon, or a smoke signal. |
@tkivela I am experiencing similar issues but I'm using Typescript v3.0.1. Have you upgraded to that yet? If so, can you confirm if the errors are still gone for you? |
I'm not on TS 3.x on any Razzle project yet, sorry. |
Hola! So here's the deal, between open source and my day job and life and what not, I have a lot to manage, so I use a GitHub bot to automate a few things here and there. This particular GitHub bot is going to mark this as stale because it has not had recent activity for a while. It will be closed if no further activity occurs in a few days. Do not take this personally--seriously--this is a completely automated action. If this is a mistake, just make a comment, DM me, send a carrier pidgeon, or a smoke signal. |
ProBot automatically closed this due to inactivity. Holler if this is a mistake, and we'll re-open it. |
@mrmartineau I just tried TS 3.2.1 as tkivela said. It works like a charm. |
Problem:
When cloning the repository and installing & running examples/with-typescript the razzle script gives a lot of errors.
Steps to reproduce (are the same as in the example readme):
`
curl https://codeload.github.com/jaredpalmer/razzle/tar.gz/master | tar -xz --strip=2 razzle-master/examples/with-typescript
cd with-typescript
yarn install
yarn start
`
Notes:
As can be seen on the end of output the TypeScript version is reported as "Version: typescript 2.9.2" even though package.json has "typescript": "^2.8.3" as devDependency. This is not the root cause of the errors, but if specific TypeScript version is wanted to be run then dependency should be declared as exact version "2.8.3", yarn for some reason resolves ^2.8.3 (and infact also earlier 2.x versions) to the latest available TypeScript version.
Yarn version:
yarn --version 1.7.0
OS:
Budgie Linux 18.04 (ie. Ubuntu 18.04), up-to-date.
Output:
→ yarn start
yarn run v1.7.0
$ razzle start
WAIT Compiling...
Starting type checking and linting service...
Using 1 worker with 2048MB memory limit
Watching: /with-typescript/src
✔ success client compiled in 3s 835ms
Type checking and linting in progress...
✔ success server compiled in 1s 209ms
✅ Server-side HMR Enabled!
The text was updated successfully, but these errors were encountered: