-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade prettier to v2 #657
Comments
Duplicate of #632. It's quite breaking and still getting bugs/patches, so TSDX will update at a later date. |
Fortunately, I found this issue. I am using private fields (TS 3.8 I believe) which Is there a way to override the prettier version for the 1 "Use" in terms of linting (not building) and committing |
Sorry for delayed response, private fields actually cause some build-chain issues upstream per #679 (comment). I think we might be able to upgrade still according to some users, so that's may not be a blocker per se, but it blocks usage of the private fields feature. |
@agilgur5 Just wandered if this will be updated at any given point or do we have any timelines? Currently i get an error Thanks is advance 😄 |
@MMT-LD the PR this duplicates is scoped out for v0.16.0 to go along with TS upgrades and ESLint upgrades etc since they all affect each other (one of the issues with an all-in-one library; massive API surface and easy breakage). I'm still not sure private fields are supported however, but I think otherwise it should work. Going to lock this as it's a duplicate. |
@agilgur5 Thanks for updating me. Looking forward to that release 😉 . Thanks for maintaining such an awesome lib 👏 |
Current Behavior
the current tsdx uses prettier v1.19
Desired Behavior
upgrade prettier to v2
Versions
The text was updated successfully, but these errors were encountered: