Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade prettier to v2 #657

Closed
zhaoyao91 opened this issue Mar 31, 2020 · 6 comments
Closed

upgrade prettier to v2 #657

zhaoyao91 opened this issue Mar 31, 2020 · 6 comments
Labels
scope: dependencies Pull requests that update a dependency file solution: duplicate This issue or pull request already exists version: minor Increment the minor version when merged

Comments

@zhaoyao91
Copy link

Current Behavior

the current tsdx uses prettier v1.19

Desired Behavior

upgrade prettier to v2

Versions

  • tsdx: 0.13.1
@agilgur5
Copy link
Collaborator

agilgur5 commented Mar 31, 2020

Duplicate of #632. It's quite breaking and still getting bugs/patches, so TSDX will update at a later date.
v0.13.x will likely focus on template improvements and perhaps some minor additions, we'll see if this is ready by v0.14

@agilgur5 agilgur5 added the solution: duplicate This issue or pull request already exists label Mar 31, 2020
@agilgur5 agilgur5 added scope: dependencies Pull requests that update a dependency file version: minor Increment the minor version when merged labels Apr 11, 2020
@jneuendorf
Copy link

jneuendorf commented Apr 18, 2020

Fortunately, I found this issue. I am using private fields (TS 3.8 I believe) which prettier@v1 cannot parse. Therefore, the version of prettier somewhat relates to the TS version one can use1 (or at least to the set of useable language features). So this should be stated in the docs/README, shouldn't it?
According to the package.json the TS version is typescript@^3.7.3...

Is there a way to override the prettier version for the lint API? Maybe it would be possible in my case to just install prettier@^2.0.0 and change some setting of TSDX.


1 "Use" in terms of linting (not building) and committing

@agilgur5
Copy link
Collaborator

Sorry for delayed response, private fields actually cause some build-chain issues upstream per #679 (comment). I think we might be able to upgrade still according to some users, so that's may not be a blocker per se, but it blocks usage of the private fields feature.

@MMT-LD
Copy link

MMT-LD commented Nov 13, 2020

@agilgur5 Just wandered if this will be updated at any given point or do we have any timelines? Currently i get an error
error Parsing error: 'from' expected prettier/prettier when i use export * as something from 'something'. I know the workaround is to import then re-export but would be good if we could bump this to v2.

Thanks is advance 😄

@agilgur5
Copy link
Collaborator

@MMT-LD the PR this duplicates is scoped out for v0.16.0 to go along with TS upgrades and ESLint upgrades etc since they all affect each other (one of the issues with an all-in-one library; massive API surface and easy breakage). I'm still not sure private fields are supported however, but I think otherwise it should work.
You can workaround this by adding a resolution too.

Going to lock this as it's a duplicate.

@MMT-LD
Copy link

MMT-LD commented Nov 13, 2020

@agilgur5 Thanks for updating me. Looking forward to that release 😉 . Thanks for maintaining such an awesome lib 👏

Repository owner locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: dependencies Pull requests that update a dependency file solution: duplicate This issue or pull request already exists version: minor Increment the minor version when merged
Projects
None yet
Development

No branches or pull requests

4 participants