Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implied tokens create incomprehensible error messages #2160

Closed
RonnyPfannschmidt opened this issue Feb 28, 2012 · 10 comments
Closed

implied tokens create incomprehensible error messages #2160

RonnyPfannschmidt opened this issue Feb 28, 2012 · 10 comments
Labels

Comments

@RonnyPfannschmidt
Copy link

code like

foo a b:1

creates a incomprehensible error, cause the implied unexpected { is never explained as such

it would be much better if it reported that the implied { came after a and what tokens where expected

@TrevorBurnham
Copy link
Collaborator

Unable to replicate: http://coffeescript.org/#try:foo%20a%20b%3A1

@RonnyPfannschmidt
Copy link
Author

my misstake, a should have been a string

http://coffeescript.org/#try:foo%20%27a%27%20b%3A1 exposes the problem

@TrevorBurnham TrevorBurnham reopened this Feb 29, 2012
@TrevorBurnham
Copy link
Collaborator

Fair enough:

foo 'a' b:1

should be an error, but that error shouldn't say "Unexpected {", since there is no {.

Perhaps more generally, we could replace the message "Unexpected {" with "Unexpected object literal"... what does @michaelficarra think?

@michaelficarra
Copy link
Collaborator

Ummmmmmm. That sounds fine.

@michaelficarra
Copy link
Collaborator

@vendethiel
Copy link
Collaborator

#1096
(and we now have a better error tracking)

And ... We're under 200 issues. Whew!

@epidemian
Copy link
Contributor

And ... We're under 200 issues. Whew!

I was surprised to see so many CS notifications in my infox today, i thought it was another CS release merge/commit spree. But the closing of so many duplicated and outdated issues is a refreshing change. Thanks a lot for that, you're making the work of many others more pleasant 😄

For another numerical data point, if #2887 gets merged we'll be over 500 tests.

@vendethiel
Copy link
Collaborator

I was surprised to see so many CS notifications in my infox today

Sorry about that.

By the way, I might (I probably) have overclosed or misread things, then I'm sorry and I'll reopen asap ;).

@vendethiel
Copy link
Collaborator

See my comment :

#1096

@xixixao
Copy link
Contributor

xixixao commented Jan 22, 2014

Wrong issue, my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants