properly use passed begin/end function ptrs to get respective iterators #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. This looks good! Please undo the change to the COPYING file. I've been meaning to put together a proper contributors list / document and will get that in place. |
previously we'd ignore the passed ptrs and always call `begin()`/`end()` making the ptrs entirely useless. the new calls properly go to the passed functions on the object we want to iter on. adjusted iter test to make sure this continues working Fixes ruby-rice#103
|
I've released 2.1.2 with this change. Thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously we'd ignore the passed ptrs and always call
begin()/end()making the ptrs entirely useless.
the new calls properly go to the passed functions on the object we want to
iter on.
adjusted iter test to make sure this continues working
Fixes #103