Fix undefined behavior #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix undefined behavior. When the number of arguments to a method call is 0, then the asList vector has a size of zero. In that case, calling asList[0] is undefined behavior. On MSVC in debug mode that causes a crash. Instead, data() should be used instead. Note a second way of solving this would be to specialize the call template like this:
template<>
inline Rice::Object Rice::Object::
call(Identifier id) const
{
return protect(rb_funcall, value(), id, 0);
}
I like that better but it seemed like a more invasive change.
|
Thanks for the fix! This change looks fine to me. CI passes fine (https://travis-ci.org/github/jasonroelofs/rice/builds/749963667) though that doesn't seem to be reporting here anymore, probably due to upcoming changes to Travis. I will make some time this holiday to finalize a few things and actually get a new release out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the number of arguments to a method call is 0, then the asList vector has a size of zero. In that case, calling asList[0] is undefined behavior although with GCC it works fine in a debug mode (but per the C++ spec you aren't supposed to do that). On MSVC in debug mode that causes a crash. Instead, data() should be used instead.
Note a second way of solving this would be to specialize the call template like this:
template<>
inline Rice::Object Rice::Object::
call(Identifier id) const
{
return protect(rb_funcall, value(), id, 0);
}
I like that better but it seemed like a more invasive change.