Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moderinize Iterators #136

Merged
merged 1 commit into from
Dec 26, 2020
Merged

Moderinize Iterators #136

merged 1 commit into from
Dec 26, 2020

Conversation

cfis
Copy link
Collaborator

@cfis cfis commented Dec 23, 2020

Update iterators so they compile with C++17 which deprecates inheriting from std::iterator.

@jasonroelofs
Copy link
Collaborator

Interesting. So right now master currently has a minimum of C++14 (variadic templates), will this bump that minimum to C++17?

@cfis
Copy link
Collaborator Author

cfis commented Dec 24, 2020

It does not. This work fine in C++ 14.

@jasonroelofs jasonroelofs merged commit 7d6fe7c into ruby-rice:master Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cfis @jasonroelofs