Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an exception when wrapper is not available at addKeepAlive #194

Merged
merged 5 commits into from
Jan 2, 2024

Conversation

maxirmx
Copy link
Contributor

@maxirmx maxirmx commented Dec 27, 2023

Adresses #193

cc: @ronaldtse

This is a contribution from Metanorma (GitHub), a product of Ribose (GitHub).

@jasonroelofs
Copy link
Collaborator

This is probably ok. Only ask would be to expand on the error message to provide some more guidance. Something like "did you use keepAlive() on a method that returns a Rice-owned type?"

@maxirmx
Copy link
Contributor Author

maxirmx commented Jan 2, 2024

Done

@jasonroelofs
Copy link
Collaborator

Awesome. Thanks for diving into this!

@jasonroelofs jasonroelofs merged commit c2816a0 into ruby-rice:master Jan 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants