Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI - Angular - ErrorValidation #788

Closed
tech-gian opened this issue Jan 31, 2023 · 1 comment · Fixed by #870
Closed

WebUI - Angular - ErrorValidation #788

tech-gian opened this issue Jan 31, 2023 · 1 comment · Fixed by #870

Comments

@tech-gian
Copy link
Contributor

const errors = JSON.parse(error.response);

As I was looking into the code and "playing" around with all its aspects, I found this little bug. As I was going to create a new List with bad title (example: More than 200 characters), the controller returned me the correct error but it didn't display in the screen. I corrected the problem to my local solution as:

const errors = JSON.parse(error.response).errors;

Is it something worth mentioning/changing it in a PR or have you tracked it down?

@jasontaylordev
Copy link
Owner

Thanks for raising this issue. By design, it was supposed to be impossible to make this kind of error. But I forgot to add max length attributes to the various input elements. If you like, please raise a PR so that the input max lengths correspond to the max lengths on the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants