Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limiting Loading of External Windows and Electron.js Version Upgrade #288

Open
masood opened this issue Nov 27, 2023 · 0 comments
Open

Limiting Loading of External Windows and Electron.js Version Upgrade #288

masood opened this issue Nov 27, 2023 · 0 comments

Comments

@masood
Copy link

masood commented Nov 27, 2023

Summary:
Thank you for designing the Jasper Desktop Application and for making it open source. The application does a great job of using secure practices and limiting in-app navigation. We point to ways that these practices can be better enforced.

Platform(s) Affected:
MacOS, Windows, Linux

Steps To Reproduce:
Open the Jasper Desktop Application with --remote-debugging-port=8315. In your Chromium-based browser, navigate to localhost:8315 and interact with the application via the DevTools console.
[Navigate to Malicious Site] Within the address bar, update the location, to say, window.open(“[https://malicious.com](https://google.com/)”). This site is loaded in a new window within the application. While Jasper adds a listener on Electron’s will-navigate, it does not add a similar handler to setWindowOpenHandler().
[Keeping up-to-date w/ Electron.js]: The application uses an old version of Electron.js (v18.0.4) and Chromium (v100.0.4896.75) which is vulnerable to numerous known V8 and Blink attacks. Upgrading to an even newer version will be a great idea as well [Link]

Mir Masood Ali, PhD student, University of Illinois Chicago
Mohammad Ghasemisharif, PhD Candidate, University of Illinois Chicago
Chris Kanich, Associate Professor, University of Illinois Chicago
Jason Polakis, Associate Professor, University of Illinois Chicago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant