Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The report and aggregate commands with --json option don't work any more #329

Closed
ericguirbal opened this issue Oct 16, 2019 · 0 comments · Fixed by #330
Closed

The report and aggregate commands with --json option don't work any more #329

ericguirbal opened this issue Oct 16, 2019 · 0 comments · Fixed by #330
Labels
bug hacktoberfest help wanted

Comments

@ericguirbal
Copy link
Contributor

ericguirbal commented Oct 16, 2019 •
edited
Loading

watson report --json and watson aggregate --json fail with this error message:

TypeError: Object of type Arrow is not JSON serializable

The regression was introduced in PR #313.
@rbialon rbialon mentioned this issue Oct 16, 2019
Merged
jmaupetit pushed a commit that referenced this issue Oct 16, 2019
@rbialon @jmaupetit
Use Arrows for_json for JSON output
f46a6ae 
Arrow provides a `for_json()` function encoding Arrow objects for JSON
output. Using the default-parameter of `json.dumps()`, this function is
invoked on Arrow objects which can then be encoded for JSON output.

Reference PR: #330 

Fix #329
davidag pushed a commit to davidag/Watson that referenced this issue Oct 16, 2019
@rbialon @davidag
Fix JSON output exception on report and aggregate
4bd9a13 
Arrow provides a `for_json()` function encoding Arrow objects for JSON
output. Using the default-parameter of `json.dumps()`, this function is
invoked on Arrow objects which can then be encoded for JSON output.

Reference PR: jazzband#330

Fix jazzband#329
ericguirbal added a commit to ericguirbal/Watson that referenced this issue Oct 19, 2019
@ericguirbal
Fix aggregate command with option --json
21e4755 
PR jazzband#330 forgot to fix the aggregate command (see bug jazzband#329).
@ericguirbal ericguirbal mentioned this issue Oct 19, 2019
Merged
ericguirbal added a commit to ericguirbal/Watson that referenced this issue Oct 19, 2019
@ericguirbal
Fix aggregate command with option --json
c9a622e 
PR jazzband#330 forgot to fix the aggregate command (see bug jazzband#329).
ericguirbal added a commit to ericguirbal/Watson that referenced this issue Oct 19, 2019
@ericguirbal
Fix aggregate command with option --json
0c4bea2 
PR jazzband#330 forgot to fix the aggregate command (see bug jazzband#329).
jmaupetit pushed a commit that referenced this issue Oct 21, 2019
@ericguirbal @jmaupetit
Fix aggregate command with option --json
26371a1 
PR #330 forgot to fix the aggregate command (see bug #329).

Reference PR #331
davidag pushed a commit to davidag/Watson that referenced this issue Oct 21, 2019
@ericguirbal @davidag
Fix aggregate command with option --json
493aca5 
PR jazzband#330 forgot to fix the aggregate command (see bug
jazzband#329).

Reference PR jazzband#331
@jmaupetit jmaupetit mentioned this issue May 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug hacktoberfest help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Arrows for_json for JSON output
2 participants
@ericguirbal @jmaupetit