-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add frame functionality, posthumously recording a task #202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a very good idea. I'm pretty sure we can find someone to write the zsh completion (I don't have that kind of superpower neither :) ).
watson/cli.py
Outdated
lambda s: not s.startswith('+'), args[i + 1:] | ||
)) | ||
for i, w in enumerate(args) if w.startswith('+') | ||
)))) # pile of pancakes ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should write a (unit tested) utils for that :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought for a minute of separating that into its own function to avoid replicating code, but then I got lazy. But you are correct; separating that tag parsing into its own function and writing an unit test for that is a good idea.
I am very much a late recording kind of time tracker, so i would appreciate this functionality very much. |
I do not want to sound way too eager beaver but, I am wondering, what is the ETA for next Watson release and if this merge could be part of it? I have been working with a companion tool for Watson for some time now and it requires this modification to exist in upstream first to be installable. It is called Flubber and it is a GTK+ front-end for Watson. Feel free to check it out at https://github.com/braincow/flubber |
I would love this feature. What needs to be done to get this one merged? Perhaps I can help. |
@BuddhaOhneHals ❤️ can you help with missing zsh-completions? |
@jmaupetit @braincow Additionally I added zsh completion. I use zsh, but it's the first time I wrote completions for it. The changes seem to work just fine but a second look from someone with more experience could be helpful. |
Separate parsing of tags and add zsh completion
🤔 looks like we are in trouble with python 3.4 I've restarted the job. Let see how it goes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks! @braincow @BuddhaOhneHals I'll squash your commits.
Added: - New `add` command (#202) - Add lunar start time options to the `report` and `log` commands (#215) - Aggregate reports by day (#231) - Fish shell completion (#239) - Add support for first day of the week configuration in reports and logs (#240) - Python 3.7 support (#241) - Add `start --no-gap` and `stop --at` options (#254) Changed: - The `edit` command now checks data consistency (#203) - Current state saving is now improve when using Watson as a library (#214) - Prevent calling `get_start_time_for_period` multiple times (#219) Fixed: - Improved support for UTF-8 with Python 2 (#211) - Zsh completion for tags and projects with spaces in their names (#227) - Typos in commands output (#230, #235) - Project URL of the project in PyPI (#260) Removed: - Python 3.3 support (#210).
Added: - New `add` command (#202) - Add lunar start time options to the `report` and `log` commands (#215) - Aggregate reports by day (#231) - Fish shell completion (#239) - Add support for first day of the week configuration in reports and logs (#240) - Python 3.7 support (#241) - Add `start --no-gap` and `stop --at` options (#254) Changed: - The `edit` command now checks data consistency (#203) - Current state saving is now improve when using Watson as a library (#214) - Prevent calling `get_start_time_for_period` multiple times (#219) Fixed: - Improved support for UTF-8 with Python 2 (#211) - Zsh completion for tags and projects with spaces in their names (#227) - Typos in commands output (#230, #235) - Project URL of the project in PyPI (#260) Removed: - Python 3.3 support (#210).
Added: - New `add` command (#202) - Add lunar start time options to the `report` and `log` commands (#215) - Aggregate reports by day (#231) - Fish shell completion (#239) - Add support for first day of the week configuration in reports and logs (#240) - Python 3.7 support (#241) - Add `start --no-gap` and `stop --at` options (#254) Changed: - The `edit` command now checks data consistency (#203) - Current state saving is now improve when using Watson as a library (#214) - Prevent calling `get_start_time_for_period` multiple times (#219) Fixed: - Improved support for UTF-8 with Python 2 (#211) - Zsh completion for tags and projects with spaces in their names (#227) - Typos in commands output (#230, #235) - Project URL of the project in PyPI (#260) Removed: - Python 3.3 support (#210).
At times I found myself starting a project, stopping and afterwards editing it to input in a task I forgot to track live earlier. With this functionality it is now possible to fill in these tasks afterwards with simple command line magic instead.
Includes BASH completion and pytest unit tests. ZSH completion is missing as I do not posses that particular shell fu.