Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zsh completion for project and tag names containing spaces #227

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

jbernhard
Copy link
Contributor

This fixes a bug where project and tag names containing spaces were split on the spaces and completed as separate entities. For example, given the project name "one two three", zsh would complete "one", "two", and "three" separately. Typing

watson start o<tab>

would expand to

watson start one

but now correctly expands to

watson start one\ two\ three

@k4nar
Copy link
Collaborator

k4nar commented Oct 11, 2018

Great 👍 !

Do you know if there is a way to have it between quotes instead?

@jbernhard
Copy link
Contributor Author

If you type a quote first, it will complete without the backslashes and close the quote, e.g.

watson start 'o<tab>  ->  watson start 'one two three'

I don't know of a way to make it always use quotes, but zsh has so many options, maybe there is something...

@k4nar
Copy link
Collaborator

k4nar commented Oct 11, 2018

Ok, sounds fair enough :) . Thank you for your contribution!

@k4nar k4nar merged commit 2c94a6c into jazzband:master Oct 11, 2018
jmaupetit added a commit that referenced this pull request Mar 25, 2019
Added:

- New `add` command (#202)
- Add lunar start time options to the `report` and `log` commands (#215)
- Aggregate reports by day (#231)
- Fish shell completion (#239)
- Add support for first day of the week configuration in reports and logs (#240)
- Python 3.7 support (#241)
- Add `start --no-gap` and `stop --at` options (#254)

Changed:

- The `edit` command now checks data consistency (#203)
- Current state saving is now improve when using Watson as a library (#214)
- Prevent calling `get_start_time_for_period` multiple times (#219)

Fixed:

- Improved support for UTF-8 with Python 2 (#211)
- Zsh completion for tags and projects with spaces in their names (#227)
- Typos in commands output (#230, #235)
- Project URL of the project in PyPI (#260)

Removed:

- Python 3.3 support (#210).
@jmaupetit jmaupetit mentioned this pull request Mar 25, 2019
jmaupetit added a commit that referenced this pull request Mar 25, 2019
Added:

- New `add` command (#202)
- Add lunar start time options to the `report` and `log` commands (#215)
- Aggregate reports by day (#231)
- Fish shell completion (#239)
- Add support for first day of the week configuration in reports and logs (#240)
- Python 3.7 support (#241)
- Add `start --no-gap` and `stop --at` options (#254)

Changed:

- The `edit` command now checks data consistency (#203)
- Current state saving is now improve when using Watson as a library (#214)
- Prevent calling `get_start_time_for_period` multiple times (#219)

Fixed:

- Improved support for UTF-8 with Python 2 (#211)
- Zsh completion for tags and projects with spaces in their names (#227)
- Typos in commands output (#230, #235)
- Project URL of the project in PyPI (#260)

Removed:

- Python 3.3 support (#210).
jmaupetit added a commit that referenced this pull request Mar 25, 2019
Added:

- New `add` command (#202)
- Add lunar start time options to the `report` and `log` commands (#215)
- Aggregate reports by day (#231)
- Fish shell completion (#239)
- Add support for first day of the week configuration in reports and logs (#240)
- Python 3.7 support (#241)
- Add `start --no-gap` and `stop --at` options (#254)

Changed:

- The `edit` command now checks data consistency (#203)
- Current state saving is now improve when using Watson as a library (#214)
- Prevent calling `get_start_time_for_period` multiple times (#219)

Fixed:

- Improved support for UTF-8 with Python 2 (#211)
- Zsh completion for tags and projects with spaces in their names (#227)
- Typos in commands output (#230, #235)
- Project URL of the project in PyPI (#260)

Removed:

- Python 3.3 support (#210).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants