Feature: Fish Completion Profile #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewmeyer
changed the title
jmaupetit
previously approved these changes
Dec 4, 2018
There was a problem hiding this comment.
Hey @andrewmeyer ! Thank you for this lovely contribution. I'm not using Fish shell but the syntax looks more natural than bash or zsh 😉
docs/index.md
Outdated
| Once this is done, re-source your fish config: | ||
| `source ~/.config/fish/config.fish` | ||
|
|
||
| You will now have command completion for fish, including the completion of known projects, tags, and frames`. |
There was a problem hiding this comment.
Suggested change
| You will now have command completion for fish, including the completion of known projects, tags, and frames`. | |
| You will now have command completion for fish, including the completion of known projects, tags, and frames. |
|
I realized that there are several more flags to add into this, I should be able to keep poking at this throughout the week to get parity between the auto completion and the command documentation section. I'll remove the WIP flag and @ someone for a final review |
andrewmeyer
changed the title
|
@k4nar do you speak Fish? |
|
@andrewmeyer If you think we are good here, can you squash your commits? Then I'll merge this. |
initial development work performed in https://github.com/andrewmeyer/fish-completions expand documentation expands documentation to include instructions on installing and activating the fish completion script for watson. provide lists of projects and tags for report/log Extends the autocomplete functionality for log and report. If -T/-p are provided, autocomplete a list of tags and projects
andrewmeyer
force-pushed
the
fish-autocomplete
branch
from
119ab9f to
cc133aa
Compare
|
@jmaupetit Thanks, everything should be squashed now. I've been using this for a week and I think I have worked out all of the features I commonly use. If something comes up I can always open another PR with bug fixes. |
|
Sounds perfect! Thanks. |
jmaupetit
approved these changes
Dec 13, 2018
Closed
jmaupetit
added a commit
that referenced
this pull request
Mar 25, 2019
Added: - New `add` command (#202) - Add lunar start time options to the `report` and `log` commands (#215) - Aggregate reports by day (#231) - Fish shell completion (#239) - Add support for first day of the week configuration in reports and logs (#240) - Python 3.7 support (#241) - Add `start --no-gap` and `stop --at` options (#254) Changed: - The `edit` command now checks data consistency (#203) - Current state saving is now improve when using Watson as a library (#214) - Prevent calling `get_start_time_for_period` multiple times (#219) Fixed: - Improved support for UTF-8 with Python 2 (#211) - Zsh completion for tags and projects with spaces in their names (#227) - Typos in commands output (#230, #235) - Project URL of the project in PyPI (#260) Removed: - Python 3.3 support (#210).
Merged
jmaupetit
added a commit
that referenced
this pull request
Mar 25, 2019
Added: - New `add` command (#202) - Add lunar start time options to the `report` and `log` commands (#215) - Aggregate reports by day (#231) - Fish shell completion (#239) - Add support for first day of the week configuration in reports and logs (#240) - Python 3.7 support (#241) - Add `start --no-gap` and `stop --at` options (#254) Changed: - The `edit` command now checks data consistency (#203) - Current state saving is now improve when using Watson as a library (#214) - Prevent calling `get_start_time_for_period` multiple times (#219) Fixed: - Improved support for UTF-8 with Python 2 (#211) - Zsh completion for tags and projects with spaces in their names (#227) - Typos in commands output (#230, #235) - Project URL of the project in PyPI (#260) Removed: - Python 3.3 support (#210).
jmaupetit
added a commit
that referenced
this pull request
Mar 25, 2019
Added: - New `add` command (#202) - Add lunar start time options to the `report` and `log` commands (#215) - Aggregate reports by day (#231) - Fish shell completion (#239) - Add support for first day of the week configuration in reports and logs (#240) - Python 3.7 support (#241) - Add `start --no-gap` and `stop --at` options (#254) Changed: - The `edit` command now checks data consistency (#203) - Current state saving is now improve when using Watson as a library (#214) - Prevent calling `get_start_time_for_period` multiple times (#219) Fixed: - Improved support for UTF-8 with Python 2 (#211) - Zsh completion for tags and projects with spaces in their names (#227) - Typos in commands output (#230, #235) - Project URL of the project in PyPI (#260) Removed: - Python 3.3 support (#210).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fish Completion
This PR adds a tab completion profile to be used by the fish shell
watson helpbackend.urlis present in the config file, print it instead of a generic message when describingwatson syncChange Overview
docs
watson.fish
Test Cases