-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github workflows for checking contributing guidelines #163
Comments
This has already partially been done via pre-commit and using pre-commit.ci. You may want to add a pylint pre-commit hook, if you'd like though. |
Here's how it looked for #162: |
okay, thanks. I will add for pylint check 👍 |
So I have no issue with pylint but we are running flake8 on the code base. But, will pylint really give us much more? Flake8 seems to be the goto tool for Jazzband projects. I worry it will be too strict and we will then start getting into configuration wars as each person has their own setup and way of doing things. Flake8 seems like a sensible compromise? What are your thoughts? This is part of the reason flake8 was originally chosen as it seems to be a happy middle ground. |
I agree with having a minimal setup for configuration, I created the issue because it was mentioned here. We can go with having isort, black and flake8 only. After running pylint, it shows some valid warnings which can be changed/improved without having the pre commit check as well and not to have strictness for config. I can work on them in a different PR and close this one? |
I think thats probably a good shout for the time being. Becuase the project is so small I think trying to keep to a simple core set (as in other jazzband projects) seems sensible. But certainly do target the valid issues you have foud in pylint. 👍🏾 |
Add pylint spec check
Add Black and flake8 check
I would like to work on it.
The text was updated successfully, but these errors were encountered: