-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decimalfield should specify step=any #70
Comments
Not sure why this hasn't been implemented, I just ran into it as well. It's an easy fix, but should definitely be implemented into the field. Instead of step="any", set it to be based on the number of decimal places. ie. step=".01" for decimal places=2 on the field, etc. |
Yep that's a great idea! I think that ticket just slipped through our attention. |
I've never contributed to a project before, but I'll give it a shot. Give me a few hours and I'll be back to work it out. |
Great that you want to give it a shot! Feel free to ask any question if you can't get along. |
Stepped into this one as well, @caacree are you still working on this? I could try to write a patch for it |
@marcoala Sure, go ahead :) Cheers for stepping up. |
Sorry guys, totally forgot about this until I saw it in my email this morning. Honestly slipped my mind. Just submitted the pull request. |
Hey Greg, sorry about that the first time around. Let me know if the tests pass now (not sure if there's a way I can see TravisCI stuff inside Github or I need it installed myself?). Thanks. |
I just release django-floppyforms 1.5.0 which includes the changes for this ticket. Happy coding. |
To avoid a validation error in chrome when entering decimals, the DecimalField template should specify
See: http://blog.isotoma.com/2012/03/html5-input-typenumber-and-decimalsfloats-in-chrome/
What I have done so far is this:
Added this to input.html:
And created a new widget like this:
The text was updated successfully, but these errors were encountered: