Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest sphinx version #1135

Open
n2ygk opened this issue Mar 27, 2022 · 2 comments
Open

Upgrade to latest sphinx version #1135

n2ygk opened this issue Mar 27, 2022 · 2 comments

Comments

@n2ygk
Copy link
Member

n2ygk commented Mar 27, 2022

Is your feature request related to a problem? Please describe.

Builds started failing for pinned Sphinx<3 because of an unpinned requirement for Jinja2.
This highlights that we are well below the latest release of Sphinx 4.x so it's probably time to suck it up and figure out what's needed to upgrade.

Describe the solution you'd like

Get tox -e docs working with current versions of Sphinx, etc.

Describe alternatives you've considered

Continue to live with old pinned versions. (Jinja2 pinned version is added in #1134).

Additional context

@n2ygk n2ygk added this to the 2.0.0 milestone Mar 27, 2022
@n2ygk n2ygk modified the milestones: 2.0.0, 2.1.0 Apr 24, 2022
@mokuhasushi
Copy link

Hi, I believe the issue to be related to the package m2r.
The proposed fix is to switch to m2r2 as the latest release of m2r is dated October 2018.

Other than m2r > m2r2 is it ok to remove the pin on Jinja2 here? (Jinja2<3.1 > Jinja2)

@andreasofthings
Copy link

Indeed it is, I just pushed a branch latest-version-of-sphinx. Let me check the output later today before opening a pull request.

@n2ygk n2ygk modified the milestones: 2.1.0, Future Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants