Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master branch behind version-1.13 #399

Closed
claudep opened this issue Dec 12, 2020 · 6 comments
Closed

Master branch behind version-1.13 #399

claudep opened this issue Dec 12, 2020 · 6 comments

Comments

@claudep
Copy link
Contributor

claudep commented Dec 12, 2020

The latest release was done from the version-1.13 branch which has 4 more commits than the master branch.

@moggers87, is this wanted or just an oversight?

@moggers87
Copy link
Collaborator

I can't push to master directly. I did email @Bouke after the release, but I think he's been busy and hasn't had time to get around to pushing that branch to master yet.

@claudep
Copy link
Contributor Author

claudep commented Dec 12, 2020

If the rule is that a merge request needs an approval before being pushed to master, it's a good thing. But if only @Bouke can merge to master, then I'd consider this as a bug :-) (bus factor and all that). @Bouke, can we solve that?

@moggers87
Copy link
Collaborator

I can push to master if the commits have been reviewed, but I can't be both committer and reviewer. @Bouke doesn't have those restrictions being the repo owner, of course.

@claudep are you volunteering to become an additional maintainer? 😉

@claudep
Copy link
Contributor Author

claudep commented Dec 12, 2020

I cannot claim to be knowledgeable in every part of this package, but for the parts that I know, I would be glad to help for reviews.

@Bouke
Copy link
Collaborator

Bouke commented Dec 12, 2020

Thanks for the great enthusiasm here, this is why it's great to be part of the FOSS community! I've now merged the 1.13 branch into master. Merging things into master requires the reviewer to be a separate user from the committer. So with that in mind, @claudep's help would be great! The bus factor is certainly a thing, and that's also why I've already moved django-user-sessions over to jazzband. However that project itself is currently also limited to a single person, so that doesn't help with the bus factor. There is some activity under way that should help, so I'm awaiting their resolve.

@claudep
Copy link
Contributor Author

claudep commented Feb 25, 2021

I guess this can now be closed.

@claudep claudep closed this as completed Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants