Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pure JS client #16

Open
jb55 opened this issue Aug 22, 2022 · 7 comments
Open

Pure JS client #16

jb55 opened this issue Aug 22, 2022 · 7 comments

Comments

@jb55
Copy link
Owner

jb55 commented Aug 22, 2022

@ShahanaFarooqui wrote a pure-js commando client here: https://github.com/ShahanaFarooqui/CLN-Commando-Client

I should just switch to that instead of using the C wasm build.

@ShahanaFarooqui
Copy link

@jb55 please let me know if you need any help or information regarding this.

@kiwiidb
Copy link

kiwiidb commented Sep 30, 2022

We would love to integrate a pure-js commando client in the Alby extension. Using a JS client and a websocket proxy seems an ideal solution that would "just work". However, I haven't been able to get @ShahanaFarooqui 's client to work yet.

Also, the code feels a bit like dark magic, would be great to have some references about the steps taken during the handshake process.

@ShahanaFarooqui
Copy link

Hey @jb55, @kiwiidb I was able to reproduce the issue with CLN v0.12.0. However, I am not 100% sure if upgrading to v0.12.x is the only reason or not. I will test it with fresh 0.11.1 node and let you know the status within 1-2 days.

@jb55
Copy link
Owner Author

jb55 commented Oct 1, 2022

@ShahanaFarooqui what issue are you referring to? commando is enabled by default in v0.12.x so you won't need the commando plugin anymore.

@ShahanaFarooqui
Copy link

@lnbc1QWFyb24
Copy link

I have a pure JS version working in the browser with no polyfills necessary available here if it is useful for anyone. One caveat is that it uses Big Integer literals which cannot be polyfilled for older browsers but according to caniuse it has 94% coverage for users.

@ShahanaFarooqui
Copy link

@kiwiidb Please check here for the solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants