Incorrect locator generated for //DEPS
links to GitHub repos
#1817
Labels
bug
Something isn't working
//DEPS
links to GitHub repos
#1817
https://www.jbang.dev/documentation/guide/latest/dependencies.html#using-links-to-git-sources
says that
https://github.com/jbangdev/jbang
is converted to the locatorcom.github.jbangdev:jbang:HEAD-SNAPSHOT
. I'm seeing it being converted to ajbang:-SNAPSHOT
locator, which can't resolve.I wondered about just dropping the line in the docs, but it's possibly almost as easy to correct the locator generation to do what the docs say.
For example,
gives
I see the same thing locally with jbang 0.92.2
Tree references with an explicit commit, like
//DEPS https://github.com/holly-cummins/github-api/tree/gg287262
do generate a correct locator. If I add atree
reference to head, it works, as long asSNAPSHOT
is mentioned explicitly:Without the
SNAPSHOT
, it doesn't work:gives a locator of
com.github.holly-cummins:github-api:jar:main
, which isn't valid. (That's maybe ok, because the docs don't say it should work, I was just trying it as a workaround.)The text was updated successfully, but these errors were encountered: