-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to set JDK release #1225
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1225 +/- ##
============================================
+ Coverage 58.82% 58.84% +0.02%
- Complexity 1057 1058 +1
============================================
Files 86 86
Lines 5661 5679 +18
Branches 954 956 +2
============================================
+ Hits 3330 3342 +12
- Misses 1839 1843 +4
- Partials 492 494 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
How is This to be used ? Couldnt find a test ? |
baff2f7
to
c9ac878
Compare
Well this is the same as But the way you use it is like this: Btw, the |
It would be nice //JAVA support something like |
@quintesse can you rebase it ? conflicted with the cygwin fix. |
a shame this does not work but that's a disco API issue:
:) |
Allows the user to override the JDK release (`ga` or `ea`) when downloading a JDK by setting `JBANG_JDK_RELEASE`. Also add support for this variable and for `JBANG_JDK_VENDOR` to the jbang startup scripts. Fixes jbangdev#1224
d1a3b28
to
56fd31c
Compare
True, but that would probably introduce a bunch of issues that I definitely didn't want to deal with right now hehe
Yeah, that would indeed be cool :-) |
Rebase done |
56fd31c
to
38110e2
Compare
Fixes #1224